[security-agent] Configuration settings for security agent #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
L3n41c
reviewed
Aug 31, 2020
| @@ -436,7 +436,7 @@ func DeploymentWithClusterAgentEnabled(t *testing.T) { | |||
| defer ctx.Cleanup() | |||
|
|
|||
| name := "foo" | |||
| agentdeployment := utils.NewDatadogAgent(namespace, name, fmt.Sprintf("datadog/agent:%s", "6.14.0"), &utils.NewDatadogAgentOptions{ClusterAgentEnabled: true}) | |||
| agentdeployment := utils.NewDatadogAgent(namespace, name, fmt.Sprintf("datadog/agent:%s", "7.22.0"), &utils.NewDatadogAgentOptions{ClusterAgentEnabled: true}) | |||
There was a problem hiding this comment.
Didn’t you want to put 7.21 everywhere it was 6.14 before ?
There was a problem hiding this comment.
Yes, it's in the DCA test though, so hopefully should not matter.
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
==========================================
+ Coverage 58.42% 58.64% +0.22%
==========================================
Files 31 31
Lines 4623 4909 +286
==========================================
+ Hits 2701 2879 +178
- Misses 1726 1815 +89
- Partials 196 215 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
clamoriniere
approved these changes
Aug 31, 2020
L3n41c
approved these changes
Aug 31, 2020
xornivore
force-pushed
the
xornivore/security-agent-settings
branch
from
5cea0bc
to
43f93ac
Compare
- Adds settings for compliance and runtime security settings in the operator for Agent 7.22.
- Addresses the issue when Cluster Agent deployment is not updated with compliance settings changes.
xornivore
force-pushed
the
xornivore/security-agent-settings
branch
from
43f93ac
to
25123c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Allow enabling security agent using operator.
Additional Notes
Anything else we should know when reviewing?