Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pod anti affinity #144

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Fix pod anti affinity #144

merged 1 commit into from
Sep 2, 2020

Conversation

ahmed-mez
Copy link
Contributor

What does this PR do?

  • Make sure we set the correct labels for CLC runner pod anti affinity
  • Remove the default pod anti affinity from the DCA, it's not required - two DCAs can live on the same node

Motivation

Before this fix two CLC runners can be scheduled on the same node, which messes up the clc dispatching

Additional Notes

Can be easily tested on a 1 node cluster

@ahmed-mez ahmed-mez added bug Something isn't working component/controller labels Sep 1, 2020
@ahmed-mez ahmed-mez added this to the v0.4 milestone Sep 1, 2020
@ahmed-mez ahmed-mez requested a review from a team as a code owner September 1, 2020 10:22
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2020

Codecov Report

Merging #144 into master will increase coverage by 5.36%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   58.42%   63.79%   +5.36%     
==========================================
  Files          31       31              
  Lines        4623     5372     +749     
==========================================
+ Hits         2701     3427     +726     
- Misses       1726     1747      +21     
- Partials      196      198       +2     
Flag Coverage Δ
#unittests 63.79% <100.00%> (+5.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/datadogagent/utils.go 89.07% <ø> (+5.91%) ⬆️
pkg/controller/datadogagent/clusteragent.go 78.35% <100.00%> (+2.87%) ⬆️
pkg/controller/datadogagent/clusterchecksrunner.go 73.91% <100.00%> (+1.27%) ⬆️
pkg/controller/datadogagent/systemprobe.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c762e52...63e90b4. Read the comment docs.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@ahmed-mez ahmed-mez merged commit 4faeb97 into master Sep 2, 2020
@clamoriniere clamoriniere deleted the ahmed-mez/clc-anti-affinity branch September 17, 2020 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component/controller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants