Add DatadogMetrics example in OLM #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cedric lamoriniere <cedric.lamoriniere@datadoghq.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
xornivore
approved these changes
Sep 1, 2020
Codecov Report
@@ Coverage Diff @@
## master #146 +/- ##
=======================================
Coverage 58.64% 58.64%
=======================================
Files 31 31
Lines 4909 4909
=======================================
Hits 2879 2879
Misses 1815 1815
Partials 215 215
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a
DatadogMetricsin the OLM ClusterServiceVersion patch.Motivation
Since we package the
DatadogMetricsCRD in the OLM configuration. we also need to have an example to be validated by the Operatorhub.io CI process.Additional Notes
Anything else we should know when reviewing?
Test plan
Generate a new Release locally with
make pre-releasecommand, then go to https://operatorhub.io/preview and copy/paste the content of the generatedcsvfile. The DatadogMetrics example should be present in the description of the Operator.