-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[system-probe] Add missing system probe settings for parity with helm chart #149
Conversation
… chart Adds missing toggles for OOMKill and TCPQueueLength modules as well as collectDNSStats setting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request contains a valid label.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request contains a valid label.
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
==========================================
+ Coverage 58.68% 58.96% +0.27%
==========================================
Files 31 31
Lines 4909 4942 +33
==========================================
+ Hits 2881 2914 +33
Misses 1814 1814
Partials 214 214
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SystemProbeLibModulesVolumeName = "modules" | ||
SystemProbeLibModulesVolumePath = "/lib/modules" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are missing the "kernelHeader folder"
@L3n41c could you confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the kernel headers are looked for in /lib/modules/$(uname -r)/build
which is generally a symlink to /usr/src/kernel-$(uname-r)
.
So, mounting the modules
and src
volumes defined here should be fine.
👍🏻
SystemProbeLibModulesVolumeName = "modules" | ||
SystemProbeLibModulesVolumePath = "/lib/modules" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the kernel headers are looked for in /lib/modules/$(uname -r)/build
which is generally a symlink to /usr/src/kernel-$(uname-r)
.
So, mounting the modules
and src
volumes defined here should be fine.
👍🏻
What does this PR do?
Adds missing toggles for
OOMKill
andTCPQueueLength
modules as well ascollectDNSStats
setting.Motivation
Parity with the helm chart in terms of full set of system probe features.
Additional Notes
Adding unit tests for these and similar features (hello security agent!) becomes rather tedious and results in rather repetitive code, there might be some quick wins in terms of refactoring to use more helper functions and injecting additional volumes, mounts. It would be ideal to keep that refactoring separate from these changes here.
Describe your test plan
Configure
DatadogAgent
CR with desired features and make sure they are properly enabled: