Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually use securityContext attribute as PodSecurityContext #150

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

vboulineau
Copy link
Contributor

What does this PR do?

Actually use securityContext attribute as PodSecurityContext

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Use the SecurityContext attribute and verify that it's effectively used as PodSecurityContext in DaemonSet

@vboulineau vboulineau added the bug Something isn't working label Sep 14, 2020
@vboulineau vboulineau added this to the v0.3 milestone Sep 14, 2020
@vboulineau vboulineau requested a review from a team September 14, 2020 16:37
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2020

Codecov Report

Merging #150 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #150   +/-   ##
=======================================
  Coverage   58.96%   58.97%           
=======================================
  Files          31       31           
  Lines        4942     4943    +1     
=======================================
+ Hits         2914     2915    +1     
  Misses       1814     1814           
  Partials      214      214           
Flag Coverage Δ
#unittests 58.97% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/datadogagent/utils.go 82.60% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20bdcff...62f90b9. Read the comment docs.

@clamoriniere clamoriniere modified the milestones: v0.3, v0.4 Sep 15, 2020
@vboulineau vboulineau merged commit 6ff73b1 into master Sep 16, 2020
@vboulineau vboulineau deleted the vboulineau/pod_security_context branch September 16, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants