Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collectEvents at Cluster Agent level #154

Conversation

carloscastrojumo
Copy link
Contributor

What does this PR do?

Add the property collectEvents at clusterAgent config to enable setting DD_COLLECT_KUBERNETES_EVENTS env var.

Motivation

Collecting Kubernetes events using the Cluster Agent instead of Node Agents.

Additional Notes

Based on the Event Collection documentation for Cluster Agent.

@codecov-commenter
Copy link

Codecov Report

Merging #154 into master will decrease coverage by 0.77%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
- Coverage   59.02%   58.24%   -0.78%     
==========================================
  Files          31       31              
  Lines        4961     4514     -447     
==========================================
- Hits         2928     2629     -299     
+ Misses       1817     1680     -137     
+ Partials      216      205      -11     
Flag Coverage Δ
#unittests 58.24% <100.00%> (-0.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/datadogagent/clusteragent.go 68.79% <100.00%> (-1.16%) ⬇️
pkg/secrets/utils.go 85.71% <0.00%> (-4.29%) ⬇️
pkg/controller/datadogagent/finalizer.go 34.78% <0.00%> (-3.68%) ⬇️
pkg/controller/datadogagent/common_configmap.go 59.74% <0.00%> (-2.62%) ⬇️
pkg/controller/datadogagent/secret.go 54.54% <0.00%> (-2.60%) ⬇️
cmd/kubectl-datadog/flare/replacer.go 85.96% <0.00%> (-2.45%) ⬇️
pkg/controller/datadogagent/common_rbac.go 73.86% <0.00%> (-2.43%) ⬇️
...ontroller/datadogagent/clusterchecksrunner_rbac.go 70.37% <0.00%> (-2.05%) ⬇️
pkg/controller/utils/datadog/metrics_forwarder.go 40.46% <0.00%> (-2.01%) ⬇️
pkg/controller/datadogagent/service.go 80.88% <0.00%> (-1.98%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3311375...3c11516. Read the comment docs.

Copy link
Contributor

@ahmed-mez ahmed-mez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution

@clamoriniere clamoriniere added this to the v0.4 milestone Oct 2, 2020
@clamoriniere clamoriniere merged commit 54ac0b1 into DataDog:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants