Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helm chart path #156

Merged
merged 1 commit into from Oct 12, 2020
Merged

Fix helm chart path #156

merged 1 commit into from Oct 12, 2020

Conversation

arapulido
Copy link
Contributor

In newer versions of the operator, untaring the release gives you directly the Helm chart. Fixing that in the installation instructions

In newer versions of the operator, untaring the release gives you directly the Helm chart. Fixing that in the installation instructions
@arapulido arapulido requested review from a team as code owners October 1, 2020 12:47
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, documentation

@arapulido arapulido added the documentation Improvements or additions to documentation label Oct 1, 2020
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2020

Codecov Report

Merging #156 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #156   +/-   ##
=======================================
  Coverage   58.21%   58.21%           
=======================================
  Files          31       31           
  Lines        4511     4511           
=======================================
  Hits         2626     2626           
  Misses       1680     1680           
  Partials      205      205           
Flag Coverage Δ
#unittests 58.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e660ed9...e91a0a3. Read the comment docs.

Copy link
Collaborator

@clamoriniere clamoriniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @arapulido

we know have the datadog-operator available on helm hub: https://hub.helm.sh/charts/datadog/datadog-operator

we need to update completely this doc page with simpler instructions.

helm repo add datadog https://helm.datadoghq.com

helm install datadog/datadog-operator 

would you like to update this doc with the new registry? no worries if not. we will do it soon.

Copy link
Contributor

@ruthnaebeck ruthnaebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for docs

@clamoriniere clamoriniere merged commit a8acfe8 into master Oct 12, 2020
@clamoriniere clamoriniere deleted the arapulido/fix-helm-chart-path branch October 12, 2020 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants