Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger internal image generation #270

Merged
merged 1 commit into from Apr 7, 2021
Merged

Conversation

clamoriniere
Copy link
Collaborator

What does this PR do?

Add new gitlab job to generate internal image build.

Motivation

Simplify release process.

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Write there any instructions and details you may have to test your PR.

@clamoriniere clamoriniere added the enhancement New feature or request label Apr 6, 2021
@clamoriniere clamoriniere added this to the v0.6 milestone Apr 6, 2021
@clamoriniere clamoriniere requested a review from a team as a code owner April 6, 2021 20:06
.gitlab-ci.yml Outdated Show resolved Hide resolved
@clamoriniere clamoriniere force-pushed the clamoriniere/internal-image branch 2 times, most recently from e9b963e to 105eb8f Compare April 7, 2021 17:29

trigger_internal_image:
stage: release
rules:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should have

  rules:
    - if: $CI_COMMIT_TAG
    - when: never

And needs on build_image_arm64 and build_image_amd64 otherwise it won't trigger automatically on tag

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@clamoriniere clamoriniere merged commit beb3be1 into main Apr 7, 2021
@clamoriniere clamoriniere deleted the clamoriniere/internal-image branch April 7, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants