Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clusterrole for kustomize #295

Merged
merged 2 commits into from
May 3, 2021
Merged

fix clusterrole for kustomize #295

merged 2 commits into from
May 3, 2021

Conversation

celenechang
Copy link
Contributor

What does this PR do?

Fix one more RBAC issue for kustomize deploys

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Write there any instructions and details you may have to test your PR.

@celenechang celenechang requested a review from a team as a code owner May 3, 2021 17:08
@celenechang celenechang added this to the v0.7 milestone May 3, 2021
@celenechang celenechang added the bug Something isn't working label May 3, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2021

Codecov Report

Merging #295 (75c57f0) into main (e026d84) will increase coverage by 21.66%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #295       +/-   ##
===========================================
+ Coverage   36.59%   58.25%   +21.66%     
===========================================
  Files          61       59        -2     
  Lines       10233     6296     -3937     
===========================================
- Hits         3745     3668       -77     
+ Misses       6211     2358     -3853     
+ Partials      277      270        -7     
Flag Coverage Δ
unittests 58.25% <ø> (+21.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/datadogagent_controller.go 60.60% <ø> (ø)
api/v1alpha1/zz_generated.openapi.go
api/v1alpha1/zz_generated.deepcopy.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e026d84...75c57f0. Read the comment docs.

@celenechang celenechang merged commit e70c981 into main May 3, 2021
@celenechang celenechang deleted the celene/fix_clusterrole branch May 3, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants