Create unit-test helper functions #301
Conversation
Codecov Report
@@ Coverage Diff @@
## main #301 +/- ##
=======================================
Coverage 58.22% 58.22%
=======================================
Files 59 59
Lines 6300 6300
=======================================
Hits 3668 3668
Misses 2362 2362
Partials 270 270
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
clamoriniere
changed the title
clamoriniere
force-pushed
the
clamoriniere/unit-test-v2
branch
from
233c0a2
to
f6aee9b
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
clamoriniere
force-pushed
the
clamoriniere/unit-test-v2
branch
from
f6aee9b
to
60a3d14
Compare
| } | ||
|
|
||
| // CheckLabelIsNotPresent used to check if a label (key,value) is not present on a metav1.ObjectMeta object. | ||
| func CheckLabelIsNotPresent(key string) CheckObjectMeta { |
There was a problem hiding this comment.
As the functions return the CheckObjectMeta meta type, we cannot easily combine them, e.g. wrapping CheckLabelIsPresent in a not or something, meaning that we'll have to provide a helper each time (regexp, not regexp, etc.)
There was a problem hiding this comment.
Do you see a solution?
There was a problem hiding this comment.
Maybe we could change to func Check(runtime.Object) bool and use a typed struct to inject other parameters.
Something like:
CheckLabelIsPresent{label: <some_key>}
with func (*CheckLabelIsPresent) Check(runtime.Object) bool
There was a problem hiding this comment.
@vboulineau done
What does this PR do?
Create new unittest helper to verify specific part of a PodTemplate, DS, EDS
Motivation
easy unit-tests maintenance
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Write there any instructions and details you may have to test your PR.