-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support global registry configuration #309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few ideas to provide more options to the user.
Codecov Report
@@ Coverage Diff @@
## main #309 +/- ##
==========================================
+ Coverage 58.18% 58.36% +0.18%
==========================================
Files 59 59
Lines 6294 6288 -6
==========================================
+ Hits 3662 3670 +8
+ Misses 2362 2348 -14
Partials 270 270
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
It will conflict a bit with #303 (see usage of |
@vboulineau do you want to merge #303 first? |
1975795
to
fed21ee
Compare
fed21ee
to
f33c7ca
Compare
f33c7ca
to
bfe0d67
Compare
What does this PR do?
Support a global registry config.
Motivation
Configure the container registry without depending on the image name and tag.
Additional Notes
For backward compatibility, the tag and registry values are ignored in case Image.Name corresponds to a full image name.
Describe your test plan
Example CR: