Add /var/log/containers to the list of mounted paths.
#310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #310 +/- ##
==========================================
+ Coverage 63.49% 63.58% +0.09%
==========================================
Files 61 61
Lines 6686 6704 +18
==========================================
+ Hits 4245 4263 +18
Misses 2134 2134
Partials 307 307
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
clamoriniere
force-pushed
the
remeh/containersymlinkspath
branch
from
1ebe9a7
to
d3af1b0
Compare
vboulineau
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mount volume
/var/log/containers. If it contains symlinks to logs of container running in a pod, the Datadog Agent (>= 7.29.0) could use it to validate what container it is tailing logs for.Motivation
Improve the logs file scanning for short-lived containers.
Additional Notes
It is a best-effort, if not available / not containing symlinks, the Datadog Agent won't use
/var/log/containers.Describe your test plan
See DataDog/datadog-agent#8143 test plan.