Fix management of seccomp ConfigMap when not used #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
clamoriniere
approved these changes
May 21, 2021
jtappa
suggested changes
May 21, 2021
vboulineau
force-pushed
the
vboulineau/fix-seccomp-config
branch
from
9380f9c
to
fbe4fd1
Compare
Codecov Report
@@ Coverage Diff @@
## main #311 +/- ##
==========================================
+ Coverage 58.18% 58.22% +0.03%
==========================================
Files 59 59
Lines 6294 6300 +6
==========================================
+ Hits 3662 3668 +6
Misses 2362 2362
Partials 270 270
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently the operator always mount the seccomp volumes, even if we use a seccomp profile from host (e.g. no install performed in init container), while the ConfigMap is not created, creating PODs referencing non-existing ConfigMaps.
Also, the ConfigMap was never deleted if setting was changed from using seccomp profile from ConfigMap to using profile from host.
Took the opportunity to change the way we do diffs in tests.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Deploy the Agent with
system-probeenabled. Then change the DatadogAgent set theSecCompProfileNameattribute tounconfined. The new DaemonSet should start properly and the ConfigMap named<dda.Name>-system-probe-seccompshould be deleted.