Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dca] add daemonsets list/watch for the cluster-agent #314

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

nammn
Copy link
Contributor

@nammn nammn commented May 26, 2021

What does this PR do?

Adds the daemonsets rbac rules. We already define them here:

datadoghqv1alpha1.DaemonsetsResource,
},
Verbs: []string{datadoghqv1alpha1.GetVerb},
. But they are only support GET while for the orchestrator explorer we need LIST and WATCH as well.

Related agent PR: DataDog/datadog-agent#8119 (collects daemonsets on the DCA)

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Write there any instructions and details you may have to test your PR.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, documentation

@nammn nammn added the enhancement New feature or request label May 26, 2021
@nammn nammn marked this pull request as ready for review May 26, 2021 08:32
@nammn nammn requested a review from a team as a code owner May 26, 2021 08:32
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2021

Codecov Report

Merging #314 (6a0a733) into main (023cb3b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #314   +/-   ##
=======================================
  Coverage   58.18%   58.18%           
=======================================
  Files          59       59           
  Lines        6294     6294           
=======================================
  Hits         3662     3662           
  Misses       2362     2362           
  Partials      270      270           
Flag Coverage Δ
unittests 58.18% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/datadogagent/clusteragent.go 69.35% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 023cb3b...6a0a733. Read the comment docs.

@clamoriniere clamoriniere added this to the v0.7 milestone Jun 1, 2021
@clamoriniere clamoriniere merged commit b802426 into main Jun 1, 2021
@clamoriniere clamoriniere deleted the nnguyen/daemonsets-rbacs branch June 1, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants