Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set runtime security custom policy using config map #315

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

lebauce
Copy link
Contributor

@lebauce lebauce commented May 27, 2021

Allow either adding a custom policy for runtime security or overriding the default one through a configmap.
Motivation

The default policy is part of the base image but was overridden by the configmap. Every time we bumped the
default policy we had to also bump the configmap. As the policy is tied to the runtime security agent, it
introduced hard to address compatibilities issues.

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Write there any instructions and details you may have to test your PR.

@lebauce lebauce requested a review from a team as a code owner May 27, 2021 13:35
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, documentation

@lebauce lebauce force-pushed the lebauce/do-not-override-default-policy branch 3 times, most recently from 491133c to 606c606 Compare May 27, 2021 18:45
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2021

Codecov Report

Merging #315 (6e82292) into main (8b4b796) will decrease coverage by 0.15%.
The diff coverage is 55.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
- Coverage   58.22%   58.06%   -0.16%     
==========================================
  Files          59       59              
  Lines        6300     6312      +12     
==========================================
- Hits         3668     3665       -3     
- Misses       2362     2376      +14     
- Partials      270      271       +1     
Flag Coverage Δ
unittests 58.06% <55.31%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/datadogagent/utils.go 81.11% <54.34%> (-0.96%) ⬇️
controllers/datadogagent/systemprobe.go 96.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b4b796...6e82292. Read the comment docs.

@lebauce lebauce added the enhancement New feature or request label May 27, 2021
@lebauce lebauce force-pushed the lebauce/do-not-override-default-policy branch 4 times, most recently from ab7f41a to 6e82292 Compare May 28, 2021 16:35
@lebauce lebauce force-pushed the lebauce/do-not-override-default-policy branch from 6e82292 to 288ed69 Compare June 3, 2021 10:09
@vboulineau vboulineau merged commit 959b205 into main Jun 3, 2021
@vboulineau vboulineau deleted the lebauce/do-not-override-default-policy branch June 3, 2021 13:16
@ahmed-mez ahmed-mez added this to the v0.7 milestone Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants