Introduce custom ConfigMap for system-probe and move built-in configuration to ENV vars #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
vboulineau
force-pushed
the
vboulineau/sysprobe
branch
from
c98f6d6
to
6eb9880
Compare
ruthnaebeck
suggested changes
May 27, 2021
| @@ -3464,6 +3464,30 @@ spec: | |||
| to connect to the netlink/conntrack subsystem to add NAT | |||
| information to connection data. See also: http://conntrack-tools.netfilter.org/' | |||
| type: boolean | |||
| customConfig: | |||
| description: Allow to put custom configuration for system-probe, | |||
There was a problem hiding this comment.
Suggested change
| description: Allow to put custom configuration for system-probe, | |
| description: Enable custom configuration for system-probe, |
| file content. | ||
| type: string | ||
| configMap: | ||
| description: ConfigMap name of a ConfigMap used to mount |
There was a problem hiding this comment.
Suggested change
| description: ConfigMap name of a ConfigMap used to mount | |
| description: The name of a ConfigMap used to mount |
| content. | ||
| type: string | ||
| name: | ||
| description: Name the ConfigMap name. |
There was a problem hiding this comment.
Suggested change
| description: Name the ConfigMap name. | |
| description: The name the ConfigMap name. |
| @@ -3334,6 +3334,29 @@ spec: | |||
| to connect to the netlink/conntrack subsystem to add NAT information | |||
| to connection data. See also: http://conntrack-tools.netfilter.org/' | |||
| type: boolean | |||
| customConfig: | |||
| description: Allow to put custom configuration for system-probe, | |||
There was a problem hiding this comment.
Suggested change
| description: Allow to put custom configuration for system-probe, | |
| description: Enable custom configuration for system-probe, |
| file content. | ||
| type: string | ||
| configMap: | ||
| description: ConfigMap name of a ConfigMap used to mount |
There was a problem hiding this comment.
Suggested change
| description: ConfigMap name of a ConfigMap used to mount | |
| description: The name of a ConfigMap used to mount |
| content. | ||
| type: string | ||
| name: | ||
| description: Name the ConfigMap name. |
There was a problem hiding this comment.
Suggested change
| description: Name the ConfigMap name. | |
| description: The name the ConfigMap name. |
vboulineau
force-pushed
the
vboulineau/sysprobe
branch
from
6eb9880
to
c6d2dab
Compare
|
@ruthnaebeck I've integrated 2 of your suggestions and entirely rephrased the other one as the pre-existing doc phrase was not clear enough. Let me know if it's good to go. |
lebauce
reviewed
May 31, 2021
vboulineau
force-pushed
the
vboulineau/sysprobe
branch
from
c6d2dab
to
2ee6032
Compare
clamoriniere
approved these changes
Jun 1, 2021
…ration to ENV vars
vboulineau
force-pushed
the
vboulineau/sysprobe
branch
from
12acb47
to
78de192
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently the Operator uses config file instead of ENV vars, which means users cannot use a custom configuration file.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Deploy the Operator with:
CustomConfigor using a custom ConfigMap name.