Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CLC manifest when custom RuntimeDir is used #318

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

vboulineau
Copy link
Contributor

What does this PR do?

Currently CLC are broken when Security Agent is activated and policiesDir option is used.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Create DatadogAgent with CLC and custom security policies:

        runtime:
          enabled: true
          policiesDir:
            configMapName: security-runtime-policies

@vboulineau vboulineau added the bug Something isn't working label Jun 7, 2021
@vboulineau vboulineau added this to the v0.6 milestone Jun 7, 2021
@vboulineau vboulineau requested a review from a team as a code owner June 7, 2021 18:18
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2021

Codecov Report

Merging #318 (1eec235) into main (f95658e) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #318      +/-   ##
==========================================
+ Coverage   58.37%   58.41%   +0.03%     
==========================================
  Files          60       60              
  Lines        6355     6361       +6     
==========================================
+ Hits         3710     3716       +6     
  Misses       2370     2370              
  Partials      275      275              
Flag Coverage Δ
unittests 58.41% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/datadogagent/clusterchecksrunner.go 76.20% <100.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f95658e...1eec235. Read the comment docs.

@vboulineau vboulineau merged commit 8072ba9 into main Jun 8, 2021
@vboulineau vboulineau deleted the vboulineau/operator-fixes branch June 8, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants