Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for system-probe extra volumeMounts #323

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

vboulineau
Copy link
Contributor

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Set agent.systemProbe.volumeMounts, the extra volumeMounts should be set in system-probe container.

@vboulineau vboulineau added this to the v0.7 milestone Jun 14, 2021
@vboulineau vboulineau requested review from a team as code owners June 14, 2021 10:06
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2021

Codecov Report

Merging #323 (4c326ff) into main (60c6bf4) will increase coverage by 22.87%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #323       +/-   ##
===========================================
+ Coverage   35.55%   58.42%   +22.87%     
===========================================
  Files          62       60        -2     
  Lines       10665     6360     -4305     
===========================================
- Hits         3792     3716       -76     
+ Misses       6592     2370     -4222     
+ Partials      281      274        -7     
Flag Coverage Δ
unittests 58.42% <100.00%> (+22.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/v1alpha1/datadogagent_types.go 100.00% <ø> (ø)
controllers/datadogagent/utils.go 81.61% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60c6bf4...4c326ff. Read the comment docs.

@vboulineau vboulineau merged commit 1ac42df into main Jun 14, 2021
@vboulineau vboulineau deleted the vboulineau/operator-fixes branch June 14, 2021 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants