Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pod name as cluster check runner ID #326

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Conversation

ahmed-mez
Copy link
Contributor

What does this PR do?

Use the pod name as cluster check runner ID to allow deploying multiple cluster check runners on the same node. (Requires agent 7.27.0+)

Additional Notes

Related to DataDog/helm-charts#275

Describe your test plan

agent clusterchecks should show how the cluster agent identifies the runners by their pod names

@ahmed-mez ahmed-mez added this to the v0.7 milestone Jun 24, 2021
@ahmed-mez ahmed-mez requested a review from a team as a code owner June 24, 2021 13:50
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2021

Codecov Report

Merging #326 (09cc2f2) into main (022a88e) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
+ Coverage   58.43%   58.49%   +0.06%     
==========================================
  Files          60       60              
  Lines        6361     6371      +10     
==========================================
+ Hits         3717     3727      +10     
  Misses       2370     2370              
  Partials      274      274              
Flag Coverage Δ
unittests 58.49% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/datadogagent/clusterchecksrunner.go 76.85% <100.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 022a88e...09cc2f2. Read the comment docs.

@ahmed-mez ahmed-mez merged commit 0a9f32b into main Jun 24, 2021
@ahmed-mez ahmed-mez deleted the ahmed/clc-runner-pod-id branch June 24, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants