Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only copy runtime policies when enabled #328

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Conversation

lebauce
Copy link
Contributor

@lebauce lebauce commented Jun 28, 2021

What does this PR do?

Only copy the runtime security policies when runtime security is enabled

Motivation

When runtime security is not enabled, one init container fails:

$ k logs datadog-agent-kmr2q -c init-volume -n datadog
cp: cannot stat '/etc/datadog-agent-runtime-policies/*': No such file or directory

@lebauce lebauce requested a review from a team as a code owner June 28, 2021 15:58
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, documentation

@lebauce lebauce added the bug Something isn't working label Jun 28, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2021

Codecov Report

Merging #328 (55def66) into main (0a9f32b) will increase coverage by 0.57%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
+ Coverage   58.49%   59.07%   +0.57%     
==========================================
  Files          60       60              
  Lines        6371     6370       -1     
==========================================
+ Hits         3727     3763      +36     
+ Misses       2370     2337      -33     
+ Partials      274      270       -4     
Flag Coverage Δ
unittests 59.07% <100.00%> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/datadogagent/utils.go 84.26% <100.00%> (+2.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a9f32b...55def66. Read the comment docs.

@vboulineau vboulineau merged commit 61f5b48 into main Jun 29, 2021
@vboulineau vboulineau deleted the lebauce/fix-policy-copy branch June 29, 2021 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants