Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Dogstatsd UDS in an emptyDir by default #331

Merged
merged 3 commits into from
Jul 19, 2021

Conversation

clamoriniere
Copy link
Collaborator

@clamoriniere clamoriniere commented Jul 7, 2021

What does this PR do?

Enable by default the Unix-domain socket support in dogstatsd in every agents that can generate DSD metrics.
To share the UDS socket between container, and "emptyDir" is created

Motivation

Improve cross agent component performances when sending DSD metrics.

Additional Notes

N/A

Describe your test plan

Deploy the agent with APM and Compliance enabled, but without UDS dogstatsd enable.

  • The Volume dsdsocket should be en emptyDir.
  • The Envvar "DD_DOGSTATSD_SOCKET" should be set in agent, trace-agent, security-agent and process-agent.
  • The VolumeMount dsdsocket should be present in readOnly on trace-agent, security-agent and process-agent

@clamoriniere clamoriniere requested a review from a team as a code owner July 7, 2021 16:55
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, documentation

@clamoriniere clamoriniere added this to the v0.7 milestone Jul 7, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2021

Codecov Report

Merging #331 (158f82b) into main (5a31233) will increase coverage by 0.26%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
+ Coverage   63.21%   63.47%   +0.26%     
==========================================
  Files          60       60              
  Lines        6606     6610       +4     
==========================================
+ Hits         4176     4196      +20     
+ Misses       2126     2112      -14     
+ Partials      304      302       -2     
Flag Coverage Δ
unittests 63.47% <83.33%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/datadogagent_controller.go 60.60% <ø> (ø)
controllers/datadogagent/utils.go 83.75% <82.75%> (+1.01%) ⬆️
api/v1alpha1/datadogagent_default.go 79.48% <100.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a31233...158f82b. Read the comment docs.

@clamoriniere clamoriniere merged commit 5af66e7 into main Jul 19, 2021
@clamoriniere clamoriniere deleted the clamoriniere/uds-empty-dir branch July 19, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants