Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not default CLC and DCA replica fields #332

Merged
merged 2 commits into from
Jul 20, 2021
Merged

Conversation

ahmed-mez
Copy link
Contributor

@ahmed-mez ahmed-mez commented Jul 8, 2021

What does this PR do?

Do not default CLC and DCA replicas

Motivation

Allow using a WPA or a HPA to autoscale the DCA and CLC deployments

Describe your test plan

Do not set the replicas field in the CR + deploy a WPA/HPA targeting the deployment:

  • make sure the operator doesn't change deployment's spec and doesn't log any errors.
  • make sure the HPA/WPA is able to autoscale the deployment
  • apply some config changes to the runners in the DatadogAgent CR, make sure the deployment is updated accordingly but the replicas field managed by the HPA/WPA stays stable kg deploy datadog-cluster-checks-runner -ojson | jq .spec.replicas

@ahmed-mez ahmed-mez added enhancement New feature or request component/controller labels Jul 8, 2021
@ahmed-mez ahmed-mez added this to the v0.7 milestone Jul 8, 2021
@ahmed-mez ahmed-mez requested review from a team as code owners July 8, 2021 14:11
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2021

Codecov Report

Merging #332 (0a04ffd) into main (5a31233) will decrease coverage by 0.00%.
The diff coverage is 37.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
- Coverage   63.21%   63.20%   -0.01%     
==========================================
  Files          60       60              
  Lines        6606     6607       +1     
==========================================
  Hits         4176     4176              
- Misses       2126     2127       +1     
  Partials      304      304              
Flag Coverage Δ
unittests 63.20% <37.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/v1alpha1/datadogagent_default.go 78.82% <ø> (-0.24%) ⬇️
api/v1alpha1/datadogagent_types.go 100.00% <ø> (ø)
controllers/datadogagent/clusterchecksrunner.go 78.68% <0.00%> (-0.22%) ⬇️
controllers/datadogagent/clusteragent.go 69.79% <100.00%> (+0.02%) ⬆️
controllers/datadogagent/utils.go 82.79% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a31233...0a04ffd. Read the comment docs.

Copy link
Contributor

@sarina-dd sarina-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 docs

@ahmed-mez ahmed-mez merged commit 37ef64e into main Jul 20, 2021
@ahmed-mez ahmed-mez deleted the ahmed/allow-autoscaling branch July 20, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants