Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dca] support sts #334

Merged
merged 1 commit into from
Jul 22, 2021
Merged

[dca] support sts #334

merged 1 commit into from
Jul 22, 2021

Conversation

nammn
Copy link
Contributor

@nammn nammn commented Jul 12, 2021

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Write there any instructions and details you may have to test your PR.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, documentation

@nammn nammn added the enhancement New feature or request label Jul 12, 2021
@ahmed-mez ahmed-mez added this to the v0.7 milestone Jul 15, 2021
Copy link
Contributor

@ahmed-mez ahmed-mez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nammn thanks! please rebase 🙇

@nammn nammn marked this pull request as ready for review July 15, 2021 11:51
@nammn nammn requested a review from a team as a code owner July 15, 2021 11:51
@nammn
Copy link
Contributor Author

nammn commented Jul 15, 2021

@ahmed-mez thanks, done 👍

Copy link
Contributor

@ahmed-mez ahmed-mez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit surprised that this didn't require a unit test change 😅

@clamoriniere clamoriniere merged commit caf191d into main Jul 22, 2021
@clamoriniere clamoriniere deleted the nnguyen/collect-sts branch July 22, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants