-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support nested path in confd configmap #335
Conversation
Codecov Report
@@ Coverage Diff @@
## main #335 +/- ##
==========================================
+ Coverage 63.44% 63.49% +0.04%
==========================================
Files 60 61 +1
Lines 6614 6686 +72
==========================================
+ Hits 4196 4245 +49
- Misses 2116 2134 +18
- Partials 302 307 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
017262f
to
6eb8ac3
Compare
6eb8ac3
to
ac6dfd4
Compare
8a6a6f0
to
62e8d3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @clamoriniere !
What does this PR do?
Support nested confd path to allow multi configuration files for a check type
Items []corev1.KeyToPath
inConfigDirSpec
which allow to map a configmap key to a specific path.clusterAgent.conf.confd
.Motivation
Some checks that can be schedule by the cluster-agent can require to have
several instances.
Additional Notes
N/A
Describe your test plan
Two 2 examples are present in the
/examples/datadogagent/
folder:datadog-agent-ksm-core-custom-conf.yaml
-> mount 3 differents configuration in/etc/datadog-agent/kubernetes_state_core.d/
datadog-agent-cluster-agent-confd.yaml
-> mount a nested file in/etc/datadog-agent/conf.d/test.d/test.yaml
another extra test can be to enable "kuberenetesStateCore" with a custom config + a
clusterAgent.conf.confd
config.