fix version check to work with release candidates #336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Defaulting was not behaving properly for prelease/release candidate images because of image tag comparison using
semver
. If-0
is added to theminVersion
image being compared then prelease image tags are compared.Ref: https://github.com/Masterminds/semver#working-with-prerelease-versions
Motivation
Unexpected behavior when testing an agent release candidate
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Test a datadog agent release candidate image with
DatadogAgent
in a non-Docker environment. Make sure that theDOCKER_HOST
env var is not automatically set in the agent containers and thedocker
check does not run.