Fix runtime security config mount #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #342 +/- ##
===========================================
+ Coverage 38.09% 63.98% +25.88%
===========================================
Files 63 61 -2
Lines 11248 6694 -4554
===========================================
- Hits 4285 4283 -2
+ Misses 6656 2104 -4552
Partials 307 307
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
clamoriniere
force-pushed
the
clamoriniere/fix-runtime-security-conf
branch
from
32b230a
to
e0b8ea2
Compare
clamoriniere
force-pushed
the
clamoriniere/fix-runtime-security-conf
branch
from
e0b8ea2
to
ac8b660
Compare
CharlyF
reviewed
Jul 28, 2021
CharlyF
reviewed
Jul 28, 2021
lebauce
reviewed
Jul 29, 2021
| @@ -1761,6 +1745,14 @@ func getVolumeMountsForSecurityAgent(dda *datadoghqv1alpha1.DatadogAgent) []core | |||
| }...) | |||
| } | |||
|
|
|||
| if runtimeEnabled { | |||
There was a problem hiding this comment.
/etc/datadog-agent/runtime-security.d is not used by security-agent, only by system-probe
There was a problem hiding this comment.
I have added here, if later on it is the case.
lebauce
approved these changes
Jul 29, 2021
CharlyF
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix issue with "security-runtime" policyDir configuration. which was removing the default configuration. Now the configuration provided by
policyDirare added to the/etc/datadog-agent/runtime-security.dfolder.Motivation
give more flexibility to the runtime policies configuration.
Additional Notes
N/A
Describe your test plan
try to deploy the datadogagent with runtime-security enable. with 2 different configs
default.policyconfiguration should be present in/etc/datadog-agent/runtime-security.ddefault.policyconfiguration and thecustom.policyfiles should be presentyou can use the following configmap: