Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix defaultOverride status update #345

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

clamoriniere
Copy link
Collaborator

What does this PR do?

Compare the same golang struct to detect defaultOverride update.

Motivation

Fix untimely status update.

Additional Notes

N/A

Describe your test plan

By running the operator, you should see less update conflict.

@clamoriniere clamoriniere requested a review from a team as a code owner August 3, 2021 11:36
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, documentation

@clamoriniere clamoriniere added this to the v0.7 milestone Aug 3, 2021
@clamoriniere clamoriniere added bug Something isn't working component/controller labels Aug 3, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2021

Codecov Report

Merging #345 (9c5d17b) into main (1ded384) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #345   +/-   ##
=======================================
  Coverage   63.98%   63.98%           
=======================================
  Files          61       61           
  Lines        6694     6694           
=======================================
  Hits         4283     4283           
  Misses       2104     2104           
  Partials      307      307           
Flag Coverage Δ
unittests 63.98% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/datadogagent/controller.go 51.80% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ded384...9c5d17b. Read the comment docs.

@clamoriniere clamoriniere merged commit 1e43add into main Aug 3, 2021
@clamoriniere clamoriniere deleted the clamoriniere/fix-status-override-update branch August 3, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component/controller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants