Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nil pointer panic in system-probe config #350

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

clamoriniere
Copy link
Collaborator

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Write there any instructions and details you may have to test your PR.

@clamoriniere clamoriniere requested a review from a team as a code owner August 6, 2021 16:16
@clamoriniere clamoriniere added this to the v0.7 milestone Aug 6, 2021
@clamoriniere clamoriniere added the bug Something isn't working label Aug 6, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2021

Codecov Report

Merging #350 (e56ee39) into main (b0c187b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #350   +/-   ##
=======================================
  Coverage   64.36%   64.36%           
=======================================
  Files          62       62           
  Lines        6878     6879    +1     
=======================================
+ Hits         4427     4428    +1     
  Misses       2135     2135           
  Partials      316      316           
Flag Coverage Δ
unittests 64.36% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/datadogagent/systemprobe.go 91.48% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0c187b...e56ee39. Read the comment docs.

@clamoriniere clamoriniere force-pushed the clamoriniere/fix-panic-with-system-probe-config branch from 1e7bf26 to e56ee39 Compare August 9, 2021 11:31
@clamoriniere clamoriniere merged commit f8b6a29 into main Aug 9, 2021
@clamoriniere clamoriniere deleted the clamoriniere/fix-panic-with-system-probe-config branch August 9, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants