fix clusterrolebinding update #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
davidor
reviewed
Aug 10, 2021
| if err := r.client.Delete(context.TODO(), clusterRoleBinding); err != nil { | ||
| return reconcile.Result{}, err | ||
| } | ||
| if err := r.client.Create(context.TODO(), newClusterRoleBinding); err != nil { |
There was a problem hiding this comment.
Should we ignore the "not exists" error in the Delete above?
Not sure if the following could happen:
- Delete is successful
- Create fails because an error connection
- When the job is retried it will fail because the Delete will return "not found"
There was a problem hiding this comment.
If it was delete, we should not go again in the update function, but instead in the create function. So I think it should be ok. Worth case it will take 2 reconcile
Loop
davidor
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
ClusterRoleBinding can't be update if we change its RoleRef because this field
is immutable.
To fix the issue, we now do
DeleteandCreate.This PR also refactor the code base to define only one function responsible of updating a ClusterRoleBinding.
Motivation
In operator v0.7, the clusterchecksrunner has its owner clusterrole (not shared with the agent ds).
So to migrate from Operator v0.6, the ClusterRoleBinding need to be updated. but a simple
Update()doesn't work due to the
RoleRefimmutabilityAdditional Notes
N/A
Describe your test plan
Active=truelike hereActive=true