Standardize image defaulting #355
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
clamoriniere
force-pushed
the
clamoriniere/defaulting-images
branch
from
67d503c
to
e2cbeba
Compare
| @@ -620,7 +621,7 @@ func TestDefaultDatadogAgentSpecAgent(t *testing.T) { | |||
| UseExtendedDaemonset: NewBoolPointer(false), | |||
| Image: &ImageConfig{ | |||
| Name: "gcr.io/datadog/agent:6.26.0", | |||
| Tag: defaultAgentImageTag, | |||
| Tag: defaulting.AgentLatestVersion, | |||
There was a problem hiding this comment.
The name in the line above doesn't correspond to "latest".
There was a problem hiding this comment.
I keep Latest in the name, because it correspond to the "latest released" version.
Do you think we should find another name?
There was a problem hiding this comment.
What I meant in this case is that the Name field in the line above already includes the version (6.26.0) and it does not correspond to defaulting.AgentLatestVersion. I think that :6.26.0 shouldn't be there.
There was a problem hiding this comment.
Yes, I now understand this is a weird behaviour of the defaulting, that doesn't check if the Name contains the tag. I will try to fix it
There was a problem hiding this comment.
I have updated the defaulting logic to only set the "default tag" if the tag is not already present in the image name.
you can review the change in this commit
Codecov Report
@@ Coverage Diff @@
## main #355 +/- ##
===========================================
+ Coverage 38.76% 64.72% +25.96%
===========================================
Files 64 63 -1
Lines 11426 6898 -4528
===========================================
+ Hits 4429 4465 +36
+ Misses 6678 2114 -4564
Partials 319 319
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
What does this PR do?
Update defaulting images logic and have a dedicated package for defaulting.
The idea here is to update the Agent and Cluster-Agent image version with
the lastest stable version each time we release the Operator.
Motivation
Keep up-to-date the agent and cluster-agent when deploying a new Operator version.
Additional Notes
N/A
Describe your test plan
Deploy the example
examples/datadogagent/datadog-agent-with-credential-secret.yaml7.30.01.14.0