[DCA] [orchestrator] add pv and pvc rbac #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1359,6 +1359,17 @@ func buildClusterAgentClusterRole(dda *datadoghqv1alpha1.DatadogAgent, name, age | |||
| datadoghqv1alpha1.GetVerb, | |||
| }, | |||
| }) | |||
|
|
|||
| // PV and PVC | |||
| rbacRules = append(rbacRules, rbacv1.PolicyRule{ | |||
There was a problem hiding this comment.
it could be good to add unit-test
There was a problem hiding this comment.
could you also add RBAC in this file https://github.com/DataDog/datadog-operator/blob/main/controllers/datadogagent_controller.go#L108
like this the Operator RBAC will be automatically generated, to allow him to create the cluster-checks-runner or dca rbac
you will need to run: make generate after updating this file
clamoriniere
force-pushed
the
nnguyen/activate-pv-pvc
branch
from
3b2f66a
to
d1797a5
Compare
clamoriniere
approved these changes
Aug 26, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
add pv and pvc rbac
Motivation
collect pv and pvc for orchestrator
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Write there any instructions and details you may have to test your PR.