Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix openAPI warning in CRD definition #367

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Conversation

clamoriniere
Copy link
Collaborator

@clamoriniere clamoriniere commented Aug 25, 2021

What does this PR do?

Update CRD struct definition

the 2 OpenAPI warning was:

API rule violation: list_type_missing,./api/v1alpha1,ConfigDirSpec,Items
API rule violation: names_match,./api/v1alpha1,LogCollectionConfig,ContainerSymlinksPath

Motivation

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Write there any instructions and details you may have to test your PR.

@clamoriniere clamoriniere requested review from a team as code owners August 25, 2021 17:19
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, documentation

@clamoriniere clamoriniere added this to the v0.7 milestone Aug 25, 2021
@clamoriniere clamoriniere added the bug Something isn't working label Aug 25, 2021
@clamoriniere clamoriniere changed the title Fix openAPI warning link to CRD definition Fix openAPI warning in CRD definition Aug 25, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #367 (f409449) into v0.7 (aa76649) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             v0.7     #367   +/-   ##
=======================================
  Coverage   65.02%   65.02%           
=======================================
  Files          63       63           
  Lines        6911     6911           
=======================================
  Hits         4494     4494           
  Misses       2098     2098           
  Partials      319      319           
Flag Coverage Δ
unittests 65.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/v1alpha1/datadogagent_types.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa76649...f409449. Read the comment docs.

Copy link

@jtappa jtappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 from docs team

@clamoriniere clamoriniere merged commit c388bdc into v0.7 Aug 26, 2021
@clamoriniere clamoriniere deleted the clamoriniere/fix-openapi branch August 26, 2021 07:25
@clamoriniere clamoriniere mentioned this pull request Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants