Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PV and PVC rbac for orchestrator explorer #368

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

clamoriniere
Copy link
Collaborator

What does this PR do?

Move PV and PVC rbac in the dedicated ClusterRole that can bind the role
to the cluster-agent or cluster-check-runners depending if cluster-checks
are enabled.

Motivation

PV and PVC rbac was applied only to the cluster-agent. If the user decide
to the the check as cluster-checks the runner will not have the permission.

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Try to deploy the orchestrator explorer with cluster-checks enabled.

@clamoriniere clamoriniere requested a review from a team as a code owner August 26, 2021 14:27
@clamoriniere clamoriniere requested a review from a team August 26, 2021 14:28
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, documentation

@clamoriniere clamoriniere added this to the v0.7 milestone Aug 26, 2021
@clamoriniere clamoriniere added the bug Something isn't working label Aug 26, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2021

Codecov Report

Merging #368 (f1bd96d) into v0.7 (16fbc67) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             v0.7     #368      +/-   ##
==========================================
+ Coverage   65.07%   65.10%   +0.03%     
==========================================
  Files          63       63              
  Lines        6920     6926       +6     
==========================================
+ Hits         4503     4509       +6     
  Misses       2098     2098              
  Partials      319      319              
Flag Coverage Δ
unittests 65.10% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/datadogagent/clusteragent.go 73.01% <ø> (-0.24%) ⬇️
controllers/datadogagent/orchestrator.go 78.15% <100.00%> (+3.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16fbc67...f1bd96d. Read the comment docs.

@clamoriniere clamoriniere merged commit c57c1b2 into v0.7 Aug 26, 2021
@clamoriniere clamoriniere deleted the clamoriniere/fix-pv-pvc-rbac branch August 26, 2021 15:05
@clamoriniere clamoriniere mentioned this pull request Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants