Merge custom and bundled compliance benchmarks #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lebauce
force-pushed
the
lebauce/do-not-override-default-benchmarks
branch
from
ca8b911
to
0ca3e36
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## main #409 +/- ##
=======================================
Coverage 66.27% 66.27%
=======================================
Files 3 3
Lines 86 86
=======================================
Hits 57 57
Misses 18 18
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
lebauce
force-pushed
the
lebauce/do-not-override-default-benchmarks
branch
from
0ca3e36
to
1e4b647
Compare
lebauce
force-pushed
the
lebauce/do-not-override-default-benchmarks
branch
from
1e4b647
to
c4cfb3b
Compare
lebauce
force-pushed
the
lebauce/do-not-override-default-benchmarks
branch
from
c4cfb3b
to
fbd6559
Compare
clamoriniere
approved these changes
Jan 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Instead of replacing the /etc/datadog-agent/compliance.d directory with the content
of a configmap, merge the benchmarks bundled with the agent and the one provided
with the configmap.
Motivation
This behaviour is the same than the security policies and it allows to both add new benchmarks
and replace existing ones.
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
Write there any instructions and details you may have to test your PR.