Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for the operator in OpenShift #425

Merged
merged 5 commits into from Jan 18, 2022

Conversation

arapulido
Copy link
Contributor

What does this PR do?

It adds new documentation to deploy the operator using OLM and the OperatorHub specific to OpenShift

@arapulido arapulido requested review from a team as code owners January 11, 2022 14:17
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, refactoring, documentation

@arapulido arapulido added the documentation Improvements or additions to documentation label Jan 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2022

Codecov Report

Merging #425 (d76c5ee) into main (5a2f0c1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #425   +/-   ##
=======================================
  Coverage   61.05%   61.05%           
=======================================
  Files           3        3           
  Lines          95       95           
=======================================
  Hits           58       58           
  Misses         25       25           
  Partials       12       12           
Flag Coverage Δ
unittests 61.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a2f0c1...d76c5ee. Read the comment docs.

Comment on lines 33 to 34
clusterAgent:
config:
externalMetrics:
enabled: true
port: 5010
clusterChecksRunnerEnabled: true
replicas: 2
clusterChecksRunner:
enabled: true
replicas: 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this part is not mandatory.
the clusterAgent is enable by default with 1 replica

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Copy link
Contributor

@alai97 alai97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc review!

docs/install-openshift.md Outdated Show resolved Hide resolved
docs/install-openshift.md Outdated Show resolved Hide resolved
docs/install-openshift.md Outdated Show resolved Hide resolved
docs/install-openshift.md Outdated Show resolved Hide resolved
docs/install-openshift.md Outdated Show resolved Hide resolved
docs/install-openshift.md Outdated Show resolved Hide resolved
docs/install-openshift.md Outdated Show resolved Hide resolved
docs/install-openshift.md Outdated Show resolved Hide resolved
docs/install-openshift.md Outdated Show resolved Hide resolved
docs/install-openshift.md Outdated Show resolved Hide resolved
Co-authored-by: Austin Lai <76412946+alai97@users.noreply.github.com>
@arapulido arapulido requested a review from alai97 January 12, 2022 09:30
@arapulido
Copy link
Contributor Author

@clamoriniere any thing else before we merge? Thanks!

@clamoriniere clamoriniere merged commit 45138ae into main Jan 18, 2022
@clamoriniere clamoriniere deleted the ara.pulido/openshift_docs branch January 18, 2022 08:34
@khewonc khewonc mentioned this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants