feat: support admissionController.AgentCommunicationMode #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ahmed-mez
changed the title
ahmed-mez
force-pushed
the
ahmed/adm-injection-mode
branch
from
a8d131c
to
7087581
Compare
Codecov Report
@@ Coverage Diff @@
## main #460 +/- ##
=======================================
Coverage 60.60% 60.60%
=======================================
Files 3 3
Lines 132 132
=======================================
Hits 80 80
Misses 40 40
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
alai97
requested changes
Mar 22, 2022
alai97
reviewed
Mar 22, 2022
alai97
reviewed
Mar 22, 2022
clamoriniere
approved these changes
Apr 5, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
DD_ADMISSION_CONTROLLER_INJECT_CONFIG_LOCAL_SERVICE_NAMEMotivation
DataDog/datadog-agent#11373
Additional Notes
Related to DataDog/helm-charts#575
Describe your test plan
Same as DataDog/datadog-agent#11373 but with the operator + make sure the
servicemode works as expected.