Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DatadogAgent v2alpha1 defaulting code #477

Merged
merged 6 commits into from
May 10, 2022
Merged

Conversation

celenechang
Copy link
Contributor

What does this PR do?

Add defaulting code for DatadogAgent v2alpha1 CRD

Motivation

Additional Notes

Currently the code is not called in the reconcile loop

Describe your test plan

@celenechang celenechang added this to the v1.0.0 milestone May 4, 2022
@celenechang celenechang requested review from a team as code owners May 4, 2022 14:29
Copy link
Contributor

@kayayarai kayayarai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits

docs/configuration.v2alpha1.md Outdated Show resolved Hide resolved
docs/configuration.v2alpha1.md Outdated Show resolved Hide resolved
Copy link
Contributor

@vboulineau vboulineau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should default false default value? I am saying that because it adds an unnecessary burden to anyone adding a new feature (to keep consistent code and having a mixup of features that are defaulted to false and not some others).

Also wondering if this should not be the place where the image, registry, etc. is defaulted?

apis/datadoghq/v2alpha1/datadogagent_default.go Outdated Show resolved Hide resolved
apis/datadoghq/v2alpha1/datadogagent_default.go Outdated Show resolved Hide resolved
apis/datadoghq/v2alpha1/datadogagent_default.go Outdated Show resolved Hide resolved
docs/configuration.v2alpha1.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2022

Codecov Report

Merging #477 (472e6eb) into main (3fe793b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #477   +/-   ##
=======================================
  Coverage   59.68%   59.68%           
=======================================
  Files           3        3           
  Lines         129      129           
=======================================
  Hits           77       77           
  Misses         40       40           
  Partials       12       12           
Flag Coverage Δ
unittests 59.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fe793b...472e6eb. Read the comment docs.

@celenechang celenechang merged commit 6fea46c into main May 10, 2022
@celenechang celenechang deleted the celene/v2_defaulting branch May 10, 2022 17:02
celenechang added a commit that referenced this pull request May 18, 2022
* add v2alpha1 defaulting

* change token name, add apiutils helpers
@celenechang celenechang mentioned this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants