-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add DatadogAgent v2alpha1 defaulting code #477
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor edits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should default false
default value? I am saying that because it adds an unnecessary burden to anyone adding a new feature (to keep consistent code and having a mixup of features that are defaulted to false and not some others).
Also wondering if this should not be the place where the image
, registry
, etc. is defaulted?
Codecov Report
@@ Coverage Diff @@
## main #477 +/- ##
=======================================
Coverage 59.68% 59.68%
=======================================
Files 3 3
Lines 129 129
=======================================
Hits 77 77
Misses 40 40
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
* add v2alpha1 defaulting * change token name, add apiutils helpers
What does this PR do?
Add defaulting code for DatadogAgent v2alpha1 CRD
Motivation
Additional Notes
Currently the code is not called in the reconcile loop
Describe your test plan