Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs updates #486

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs updates #486

wants to merge 1 commit into from

Conversation

cswatt
Copy link
Contributor

@cswatt cswatt commented May 9, 2022

What does this PR do?

Edits and updates to documentation.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Describe your test plan

Write there any instructions and details you may have to test your PR.

@cswatt cswatt requested review from a team as code owners May 9, 2022 21:10
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, refactoring, documentation, tooling

@codecov-commenter
Copy link

Codecov Report

Merging #486 (4742536) into main (27d2ea8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #486   +/-   ##
=======================================
  Coverage   59.68%   59.68%           
=======================================
  Files           3        3           
  Lines         129      129           
=======================================
  Hits           77       77           
  Misses         40       40           
  Partials       12       12           
Flag Coverage Δ
unittests 59.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27d2ea8...4742536. Read the comment docs.

Comment on lines +27 to +29
```shell
curl -sL https://github.com/operator-framework/operator-lifecycle-manager/releases/download/v0.21.1/install.sh | bash -s v0.21.1
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want three spaces indent to nest this under the list item

Comment on lines +33 to +35
```shell
kubectl create -f https://operatorhub.io/install/datadog-operator.yaml
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Comment on lines +39 to +41
```shell
kubectl create -f https://operatorhub.io/install/datadog-operator.yaml
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

3. After install, you can watch your Operator come up:

```shell
kubectl create -f https://operatorhub.io/install/datadog-operator.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
kubectl create -f https://operatorhub.io/install/datadog-operator.yaml
kubectl get po -n operators

Copy link
Contributor

@celenechang celenechang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small suggestion, otherwise lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants