introduce the component package
#488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
clamoriniere
force-pushed
the
clamoriniere/defaultComponents
branch
from
4add6f5
to
2bb46e9
Compare
clamoriniere
changed the title
component package
celenechang
reviewed
May 10, 2022
| VolumeMounts: volumeMounts, | ||
| Command: nil, | ||
| Args: nil, | ||
| SecurityContext: &corev1.SecurityContext{ |
There was a problem hiding this comment.
should we make this configurable as well?
There was a problem hiding this comment.
this is the default PodTemplateSpec, so it is not configurable.
The Idea it to create later another function that will use DatadogAgent.Spec.Override to override the PodTemplate if needed. Or it will be configurable in a Feature
There was a problem hiding this comment.
sorry commented too quickly, after reviewing more i understand
celenechang
reviewed
May 11, 2022
celenechang
approved these changes
May 11, 2022
Co-authored-by: Celene <celene@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduce the
componentpackage with theNewDefaultClusterAgentPodTemplateSpecfunctionthat aims to create a default cluster-agent
PodTemplateSpecMotivation
Refactor code for the feature factory
Additional Notes
Anything else we should know when reviewing?
Describe your test plan
it is code refactoring, unit-tests and test should be green.