-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release tooling #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments.
quick question how to you plan the overwrite INVALID_SET_ME
in the file?
binary: datadog-operator | ||
- id: kubectl-datadog | ||
goos: | ||
- linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can also add windows
.goreleaser.yml
Outdated
hooks: | ||
- go mod download | ||
builds: | ||
- id: datadog-operator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need to build the datadog-operator
with goreleaser since what we deliver is the Docker image.
shortDescription: Manage the Datadog Operator | ||
description: | | ||
The datadog kubectl plugin provides useful utilities to operate datadog-agent components | ||
via the Datadog Operator and the DatadogAgent CRD. | ||
homepage: https://github.com/DataDog/datadog-operator | ||
platforms: | ||
- uri: https://github.com/DataDog/datadog-operator/releases/download/v0.0.1/datadog-darwin-amd64.zip # TODO | ||
sha256: # TODO | ||
- uri: https://github.com/DataDog/datadog-operator/releases/download/INVALID_SET_ME/kubectl-datadog_INVALID_SET_ME_darwin_amd64.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add also the windows support?
As mentioned here, the first release must be done manually, we'll have to set the right values in the It's not mandatory to keep this file |
d527317
to
2afafbb
Compare
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
=======================================
Coverage 56.96% 56.96%
=======================================
Files 31 31
Lines 4108 4108
=======================================
Hits 2340 2340
Misses 1584 1584
Partials 184 184
Continue to review full report at Codecov.
|
What does this PR do?
goreleaser
manifestkrew
manifestMotivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?