Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release tooling #56

Merged
merged 2 commits into from
Mar 30, 2020
Merged

Prepare release tooling #56

merged 2 commits into from
Mar 30, 2020

Conversation

ahmed-mez
Copy link
Contributor

What does this PR do?

  • Prepare the goreleaser manifest
  • Adapt the krew manifest

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

@ahmed-mez ahmed-mez requested a review from a team as a code owner March 27, 2020 14:35
Copy link
Collaborator

@clamoriniere clamoriniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments.

quick question how to you plan the overwrite INVALID_SET_ME in the file?

binary: datadog-operator
- id: kubectl-datadog
goos:
- linux
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can also add windows

.goreleaser.yml Outdated
hooks:
- go mod download
builds:
- id: datadog-operator
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need to build the datadog-operator with goreleaser since what we deliver is the Docker image.

shortDescription: Manage the Datadog Operator
description: |
The datadog kubectl plugin provides useful utilities to operate datadog-agent components
via the Datadog Operator and the DatadogAgent CRD.
homepage: https://github.com/DataDog/datadog-operator
platforms:
- uri: https://github.com/DataDog/datadog-operator/releases/download/v0.0.1/datadog-darwin-amd64.zip # TODO
sha256: # TODO
- uri: https://github.com/DataDog/datadog-operator/releases/download/INVALID_SET_ME/kubectl-datadog_INVALID_SET_ME_darwin_amd64.zip
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add also the windows support?

@ahmed-mez
Copy link
Contributor Author

quick question how to you plan the overwrite INVALID_SET_ME in the file?

As mentioned here, the first release must be done manually, we'll have to set the right values in the INVALID_SET_ME placeholder and open a pull request to add datadog.yaml to krew-index.
Once merged, we can automate the update of the version in krew-index via a github action triggered on every new release.

It's not mandatory to keep this file datadog.yaml in the datadog-operator repo, I'm just adding it here as a reference.

@codecov-io
Copy link

codecov-io commented Mar 30, 2020

Codecov Report

Merging #56 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   56.96%   56.96%           
=======================================
  Files          31       31           
  Lines        4108     4108           
=======================================
  Hits         2340     2340           
  Misses       1584     1584           
  Partials      184      184           
Flag Coverage Δ
#unittests 56.96% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e776ef2...2afafbb. Read the comment docs.

@ahmed-mez ahmed-mez merged commit 9571dea into master Mar 30, 2020
@ahmed-mez ahmed-mez deleted the ahmed-mez/prepare-goreleaser branch March 30, 2020 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants