change probes port, make it configurable #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
=======================================
Coverage 56.96% 56.96%
=======================================
Files 31 31
Lines 4108 4108
=======================================
Hits 2340 2340
Misses 1584 1584
Partials 184 184
Continue to review full report at Codecov.
|
26 tasks
ahmed-mez
reviewed
Mar 29, 2020
| @@ -55,12 +55,12 @@ spec: | |||
| readinessProbe: | |||
| httpGet: | |||
| path: /ready | |||
| port: 8080 | |||
| port: 9090 | |||
There was a problem hiding this comment.
shouldn't we make this configurable in values.yaml?
Signed-off-by: cedric lamoriniere <cedric.lamoriniere@datadoghq.com>
clamoriniere
force-pushed
the
clamoriniere/probes-port
branch
from
8182ff5
to
68c777d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change the probes port from
8080to9090, also make it parametrisable.Motivation
the Operatorhub.io validation process inject a container that use also the port
8080. in order to make the validation test working.Additional Notes
Anything else we should know when reviewing?