Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SecCompProfileName for system-probe #60

Merged
merged 2 commits into from
Mar 30, 2020

Conversation

clamoriniere
Copy link
Collaborator

What does this PR do?

Add secCompProfileName parameter in system-probe spec.

Motivation

In order to ease the debuging of system-probe container, add the possibility to provides another seccomp profile.

Additional Notes

Anything else we should know when reviewing?

Signed-off-by: cedric lamoriniere <cedric.lamoriniere@datadoghq.com>
@codecov-io
Copy link

codecov-io commented Mar 29, 2020

Codecov Report

Merging #60 into master will decrease coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage   56.96%   56.95%   -0.01%     
==========================================
  Files          31       31              
  Lines        4108     4112       +4     
==========================================
+ Hits         2340     2342       +2     
- Misses       1584     1585       +1     
- Partials      184      185       +1     
Flag Coverage Δ
#unittests 56.95% <60.00%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pkg/controller/datadogagent/utils.go 82.11% <60.00%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31fb89a...300d672. Read the comment docs.

Copy link
Contributor

@ahmed-mez ahmed-mez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it would be nice to add a test cases for system-probe seccomp and apparmor profiles config in datadogagent_controller_test.go

Signed-off-by: cedric lamoriniere <cedric.lamoriniere@datadoghq.com>
@clamoriniere clamoriniere merged commit 08a3634 into master Mar 30, 2020
@clamoriniere clamoriniere deleted the clamoriniere/system-probes-profile branch March 30, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants