Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Plugin] Add DD_LOG_LEVEL=off to get agent status #63

Merged
merged 1 commit into from
Mar 31, 2020
Merged

[Plugin] Add DD_LOG_LEVEL=off to get agent status #63

merged 1 commit into from
Mar 31, 2020

Conversation

ahmed-mez
Copy link
Contributor

What does this PR do?

  • Make sure agent status --json returns a valid json

Motivation

agent status --json prints the logs if DD_LOG_LEVEL is set in the agent container => invalid json

@ahmed-mez ahmed-mez added bug Something isn't working component/plugin labels Mar 31, 2020
@ahmed-mez ahmed-mez requested a review from a team as a code owner March 31, 2020 14:32
xornivore
xornivore approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@xornivore xornivore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ahmed-mez ahmed-mez merged commit 44a2148 into master Mar 31, 2020
@ahmed-mez ahmed-mez deleted the ahmed-mez/fix-possible-invalid-json branch March 31, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xornivore xornivore xornivore approved these changes

Assignees
No one assigned
Labels
bug Something isn't working component/plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahmed-mez @xornivore