Fix CLC config #64
Merged
Fix CLC config #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmed-mez
force-pushed
the
ahmed-mez/enable-endpointchecks
branch
from
53b28e1
to
25315f4
Compare
vboulineau
reviewed
Apr 3, 2020
ahmed-mez
force-pushed
the
ahmed-mez/enable-endpointchecks
branch
2 times, most recently
from
80ab2c2
to
5469f62
Compare
…datadog-operator into ahmed-mez/enable-endpointchecks
ahmed-mez
force-pushed
the
ahmed-mez/enable-endpointchecks
branch
from
5469f62
to
f32d7c4
Compare
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 57.00% 57.21% +0.21%
==========================================
Files 31 31
Lines 4112 4121 +9
==========================================
+ Hits 2344 2358 +14
+ Misses 1585 1581 -4
+ Partials 183 182 -1
Continue to review full report at Codecov.
|
clamoriniere
reviewed
Apr 6, 2020
| @@ -1662,6 +1665,7 @@ func TestReconcileDatadogAgent_Reconcile(t *testing.T) { | |||
| Labels: map[string]string{"label-foo-key": "label-bar-value"}, | |||
| Status: &datadoghqv1alpha1.DatadogAgentStatus{}, | |||
| ClusterAgentEnabled: true, | |||
| ClusterChecksEnabled: true, | |||
| ClusterChecksRunnerEnabled: true, | |||
There was a problem hiding this comment.
I think we need te remove this field.
clamoriniere
approved these changes
Apr 6, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
clusterChecksRunnerEnabledMotivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?