[kubectl plugin] Add validate and find commands #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmed-mez
force-pushed
the
ahmed-mez/add-more-plugin-cmds
branch
from
1eb1438
to
4a882f7
Compare
clamoriniere
reviewed
Apr 6, 2020
There was a problem hiding this comment.
nice PR.
I have just a proposition about how to structure the different commands to have it maybe more generic.
WDYT if we put both auto-discovery command like this
kubectl datadog validate ad pod <pod-name>
kubectl datadog validate ad service <service-name>
like this if we want to support after
kubectl datadog validate ad deployment|daemonset|statefulset <pod-name>
or others resources it will be simpler ?
Later, we can think also to implement:
kubectl datadog validate config
cmd/kubectl-datadog/find/find.go
Outdated
| func New(streams genericclioptions.IOStreams) *cobra.Command { | ||
| o := newOptions(streams) | ||
| cmd := &cobra.Command{ | ||
| Use: "find [pod name] [flags]", |
There was a problem hiding this comment.
What do you think if we move this command as a agent subcommand ?
example: kubectl datadog agent find <myapp-pod>
|
Makes perfect sense thanks! I will update the PR accordingly 👍 |
ahmed-mez
force-pushed
the
ahmed-mez/add-more-plugin-cmds
branch
from
4a882f7
to
474c334
Compare
|
@clamoriniere PR updated |
clamoriniere
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
validate ad podcommand for pod annotationsvalidate ad servicecommand for service/endpoints annotationsagent findcommand to get the agent monitoring a given podMotivation
make operations easier