Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container logs scraping from file by default #88

Merged
merged 1 commit into from
May 12, 2020

Conversation

vboulineau
Copy link
Contributor

What does this PR do?

Align with the Helm chart. We are mounting pod logs host path and container logs host path.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

@vboulineau vboulineau requested a review from a team as a code owner May 11, 2020 16:08
Copy link
Contributor

@ahmed-mez ahmed-mez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's see why e2e tests fail before merging

@vboulineau vboulineau force-pushed the vboulineau/k8s_container_file branch 2 times, most recently from 770f727 to 955f6ab Compare May 12, 2020 08:40
@codecov-io
Copy link

codecov-io commented May 12, 2020

Codecov Report

Merging #88 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   57.40%   57.43%   +0.03%     
==========================================
  Files          31       31              
  Lines        4158     4161       +3     
==========================================
+ Hits         2387     2390       +3     
  Misses       1592     1592              
  Partials      179      179              
Flag Coverage Δ
#unittests 57.43% <100.00%> (+0.03%) ⬆️
Impacted Files Coverage Δ
pkg/controller/datadogagent/utils.go 83.33% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 302f86c...955f6ab. Read the comment docs.

Align with the Helm chart. We are mounting pod logs host path and container logs host path.
@vboulineau vboulineau force-pushed the vboulineau/k8s_container_file branch from 955f6ab to 7985d71 Compare May 12, 2020 09:22
@vboulineau
Copy link
Contributor Author

LGTM but let's see why e2e tests fail before merging

Seems to be random failure, I cannot reproduce it and different runs do not yield the same failure.
I'm guessing it's due to:

2020-05-11 16:20:23 UTC | SYS-PROBE | CRITICAL | (cmd/system-probe/main.go:122 in main) | failed to create system probe: could not enable kprobe(kprobe/tcp_get_info) used for offset guessing: cannot write "p:ptcp_get_info tcp_get_info\n" to kprobe_events: write /sys/kernel/debug/tracing/kprobe_events: device or resource busy

But I'm not sure. I believe we could improve readability of e2e tests logs, I'll make another PR later for that.

@ahmed-mez
Copy link
Contributor

Thanks for looking into it, :shipit:

@vboulineau vboulineau merged commit 8b1b1fe into master May 12, 2020
@vboulineau vboulineau deleted the vboulineau/k8s_container_file branch May 12, 2020 13:39
@clamoriniere clamoriniere added this to the v0.3 milestone Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants