Add an all-in-one chart that deploys both the operator and an agent #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
=======================================
Coverage 57.19% 57.19%
=======================================
Files 31 31
Lines 4175 4175
=======================================
Hits 2388 2388
Misses 1606 1606
Partials 181 181
Continue to review full report at Codecov.
|
cohenyair
reviewed
May 20, 2020
docs/getting_started.md
Outdated
| @@ -24,140 +28,36 @@ To use the Datadog Operator, deploy it in your Kubernetes cluster. Then create a | |||
| 4. Create the namespace: | |||
|
|
|||
| ```shell | |||
| kubectl create ns $DD_NAMESPACE | |||
| kubectl create namespace $DD_NAMESPACE | |||
There was a problem hiding this comment.
@L3n41c could we remove step 3 and 4 and use the default namespace and a default deployment name? it would simplify the basic deployment even further
There was a problem hiding this comment.
Hi @cohenyair !
Thanks you for the feedback.
I’ve simplified the instructions by letting the agent being installed in the current namespace.
Can you PTAL ?
L3n41c
force-pushed
the
lenaic/chart_all-in-one
branch
from
057e93a
to
ee28ee9
Compare
clamoriniere
approved these changes
May 25, 2020
cohenyair
approved these changes
May 25, 2020
…aic/chart_all-in-one
L3n41c
force-pushed
the
lenaic/chart_all-in-one
branch
from
ecab5d8
to
ef836e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add an all-in-one chart that deploys both the operator and an agent
Motivation
Simplify on-boarding
Additional Notes
Anything else we should know when reviewing?