Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass existing DS to updateDaemonSetStatus in updateDaemonSet when no change is required #94

Conversation

mantoine96
Copy link
Contributor

What does this PR do?

This PR fixes #93

In updateDaemonSet, we create a new daemonset before checking if we need to make an update to the daemonset. Unfortunately, instead of passing the existing DS to the updateDaemonSetStatus method, we were passing the new one, which obviously had no containers running, resulting in the Agent having its status stuck in Progressing (0/0/0).

Once we pass the existing DS, the status updates as expected.

Motivation

Fixing my own issue

Additional Notes

@mantoine96 mantoine96 requested a review from a team as a code owner May 22, 2020 13:37
@codecov-commenter
Copy link

Codecov Report

Merging #94 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #94   +/-   ##
=======================================
  Coverage   57.23%   57.23%           
=======================================
  Files          31       31           
  Lines        4165     4165           
=======================================
  Hits         2384     2384           
  Misses       1600     1600           
  Partials      181      181           
Flag Coverage Δ
#unittests 57.23% <0.00%> (ø)
Impacted Files Coverage Δ
pkg/controller/datadogagent/agent.go 48.93% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 607e3ce...83e8820. Read the comment docs.

Copy link
Contributor

@ahmed-mez ahmed-mez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@ahmed-mez ahmed-mez merged commit 04f8786 into DataDog:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent status not updated
3 participants