Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

Source kube_service tags from datadog-agent tagger #103

Merged
merged 3 commits into from
Feb 13, 2018

Conversation

sunhay
Copy link
Member

@sunhay sunhay commented Feb 7, 2018

Noticed that DataDog/datadog-agent#1147 was merged in, which provides kube_service tags via the main agent tagger so I threw this quickly together.

This means we can get rid of the kubernetes package and leave all tagging to the main agent 👌

Example container output:

 {
 	"type": "Docker",
 	"id": "ae1a330995759131547ed272aa2a6f2016bc39e5d1cfc377eea25e6c0242445e",
 	"cpuLimit": 100,
 	"state": 3,
 	"created": 1518044218,
 	"netRcvdPs": 1,
 	"netSentPs": 1,
 	"netRcvdBps": 518,
 	"netSentBps": 66,
 	"memRss": 9854976,
 	"memCache": 14700544,
 	"started": 1518044220,
 	"tags": [
 		"kube_service:kube-dns",
 		"kube_deployment:kube-dns",
 		"kube_namespace:kube-system",
 		"kube_container_name:sidecar",
 		"pod_name:kube-dns-86f6f55dd5-sdskb",
 		"kube_replica_set:kube-dns-86f6f55dd5",
 		"docker_image:gcr.io/google_containers/k8s-dns-sidecar-amd64:1.14.5",
 		"image_name:gcr.io/google_containers/k8s-dns-sidecar-amd64",
 		"image_tag:1.14.5",
 		"container_name:k8s_sidecar_kube-dns-86f6f55dd5-sdskb_kube-system_7c77b2a5-dea5-11e7-bdb9-080027e5e101_16",
 		"container_id:ae1a330995759131547ed272aa2a6f2016bc39e5d1cfc377eea25e6c0242445e"
 	]
 }

Copy link
Member

@conorbranagan conorbranagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yahoo!

@sunhay sunhay force-pushed the sunhay/remove-kubernetes-package branch from 02192f8 to 957c519 Compare February 13, 2018 15:13
@sunhay sunhay merged commit 2c88693 into master Feb 13, 2018
@sunhay sunhay deleted the sunhay/remove-kubernetes-package branch February 13, 2018 15:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants