Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source substrings for eks and msk #371

Merged
merged 1 commit into from Oct 13, 2020

Conversation

robmp
Copy link
Contributor

@robmp robmp commented Oct 13, 2020

What does this PR do?

Add source substrings for eks and msk.

Motivation

Currently eks and msk logs have their source set to cloudwatch which makes it difficult to work with them.

Testing Guidelines

Tested locally.

Copy link
Contributor

@DylanLovesCoffee DylanLovesCoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks for the contribution!

@DylanLovesCoffee
Copy link
Contributor

@robmp I'm going to merge this PR for you. I'm also making some changes to the forwarder's source detection and will be rolling your contributions in #365. Thanks again!

@DylanLovesCoffee DylanLovesCoffee merged commit 0dfe42b into DataDog:master Oct 13, 2020
@robmp
Copy link
Contributor Author

robmp commented Oct 14, 2020

@robmp I'm going to merge this PR for you. I'm also making some changes to the forwarder's source detection and will be rolling your contributions in #365. Thanks again!

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants